On 10/28/2015 03:14 AM, David Turner wrote: > This version of the series makes some minor changes from v4: > > refs.c: move refname_is_safe to the common code: clarify a comment > initdb: move safe_create_dir into common code: add a caveat on safe_create_dir > refs.c: move update_ref to refs.c: update commit message to include write_pseudoref > refs.c: move delete_pseudoref and delete_ref to the common code: remove spurious > added newline > refs: make files_log_ref_write functions public: reword commit message > refs.c: move ref iterators to the common code: added my DCO because this patch changed a bunch since Ronnie wrote it Thanks for your re-roll. I think this series is almost ready. I already sent a couple of minor comments about it, plus one bigger one: wouldn't it be better to have a header file for declarations intended to be used internally by the various refs backends but not be exposed to non-refs code? I also think we agreed that the refs code could be moved to a refs/ subdirectory. So I revised your patch series, including a suggested new file naming scheme and addressing my other comments. I will submit that version shortly as v6. Otherwise it all looks good. I've checked everything rather carefully and didn't find any problems. Thanks for your patience! Michael [1] https://github.com/mhagger/git -- Michael Haggerty mhagger@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html