On Wed, Oct 28, 2015 at 12:48 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: >> >>>> -static void real_report_garbage(const char *desc, const char *path) >>>> +const char *bits_to_msg(unsigned seen_bits) >>> >>> If you don't expect other callers outside this file, then this should >>> be declared 'static'. If you do expect future external callers, then >>> this should be declared in a public header file (but renamed to be >>> more meaningful). >> >> I think this can be private to this file. The sole point of moving >> this logic to this file is to make it private, after all ;-) Thanks >> for sharp eyes. >> >> Together with the need for a description on "why", this probably >> deserves a test or two, probably at the end of t5304. >> >> Thanks. > > Does somebody want to help tying the final loose ends on this topic? > It has been listed in the [Stalled] section for too long, I _think_ > what it attempts to do is a worthy thing, and it is shame to see the > initial implementation and review cycles we have spent so far go to > waste. > > If I find nothing else to do before any taker appears, I could > volunteer myself, but thought I should ask first. > > Thanks. I agree; I've been wanting to get back to it, but had some higher-priority things at work for a while, so I've not had time. I'd be happy to get back into it, but if you get to it first, believe me, I'm not going to be offended. :) I'll see if I can't devote a little extra time to it this upcoming week, though. Hopefully it doesn't need too much additional polishing to be ready. P.S. Does a Googler want to tell the Inbox team that the inability to send plain-text email is really annoying? :P -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html