Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: >> -static void real_report_garbage(const char *desc, const char *path) >> +const char *bits_to_msg(unsigned seen_bits) > > If you don't expect other callers outside this file, then this should > be declared 'static'. If you do expect future external callers, then > this should be declared in a public header file (but renamed to be > more meaningful). I think this can be private to this file. The sole point of moving this logic to this file is to make it private, after all ;-) Thanks for sharp eyes. Together with the need for a description on "why", this probably deserves a test or two, probably at the end of t5304. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html