On Tue, Oct 13, 2015 at 12:37 AM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> If you design a new infrastructure to help refactoring early >> (i.e. before adding many copies of code that need to be cleaned up >> later), it would make the work of reviewing of the design of the >> helper and refactoring using that helper smaller, not larger. > > But most of the code concerned is already reviewed. The first instances > of the pattern to refactor is already in next. With a real time machine, > we could go back in past, refactor and then have cleaner series, but > with Git as our only tool we can't ;-). > > The current series will just add one more instance of sub-optimal code, > it isn't hard to review. Inserting new code before them would make the > interdiff far bigger. > Sorry for the delay, was a bit busy with college work. For the most part I've been trying to integrate the %(upstream) and its options 'track', 'trachshort' and 'short' so we could implement %(upstream:track,nobracket) or %(upstream:nobracket,track). While doing so I realized I was moving a lot of code around and this had me thinking it's perhaps easier to do the cleaning up first as Junio suggested. Maybe then it'd be simpler to do implement this rather than move code around now and then move code around when we implement the parsing methods we spoke about earlier? -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html