On Mon, Oct 12, 2015 at 11:15 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > >> The char buf[40] is safe (at least while the strings are not >> translated), but I'd rather avoid magic numbers like this 40 in the >> code, and use a construct that does not have this size limitation. >> Especially if it makes the code shorter. >> >> Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxx> >> --- > > The construct being fixed with this change looks very similar to > Peff's a5e03bf5 (ref-filter: drop sprintf and strcpy calls, > 2015-09-24) on jk/war-on-sprintf topic, but the new code since that > commit cleaned up. > Yes, pretty much the same. > I'd expect that this will be rolled into Karthik's series in the > next reroll? > > Looking good. Thanks. Yes, I've adding this into my series. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html