larsxschneider@xxxxxxxxx writes:
> From: Lars Schneider <larsxschneider@xxxxxxxxx>
>
> The OS X file system is case insensitive by default. Consequently this
> test does not apply.
>
> Signed-off-by: Lars Schneider <larsxschneider@xxxxxxxxx>
> ---
> t/t9819-git-p4-case-folding.sh | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/t/t9819-git-p4-case-folding.sh b/t/t9819-git-p4-case-folding.sh
> index 78f1d0f..c69ae47 100755
> --- a/t/t9819-git-p4-case-folding.sh
> +++ b/t/t9819-git-p4-case-folding.sh
> @@ -4,6 +4,11 @@ test_description='interaction with P4 case-folding'
>
> . ./lib-git-p4.sh
>
> +if test_have_prereq DARWIN; then
> + skip_all='skipping P4 case-folding tests; OS X file system is case insensitive by default'
> + test_done
> +fi
Makes one wonder what should happen on Windows, or vfat mounted on
Linux for that matter. IOW, shouldn't the prerequisite be more like
"do not run any of these tests if the filesystem does not allow us
to have two files in different cases at the same time"?
Perhaps
if ! test_have_prereq CASE_INSENSITIVE_FS
then
skip_all=...
test_done
fi
instead, or something?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html