Re: [PATCH v2 3/4] git-p4: Fix t9815 git-p4-submit-fail test case on OS X

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



larsxschneider@xxxxxxxxx writes:

> +		if test_have_prereq CYGWIN; then
> +			: # NOOP
> +		elif test_have_prereq DARWIN; then
> +			stat -f %Sp text | egrep ^-r-- &&
> +			stat -f %Sp text+x | egrep ^-r-x
> +		else
>  			stat --format=%A text | egrep ^-r-- &&
>  			stat --format=%A text+x | egrep ^-r-x
>  		fi

Not a new problem but why do we need "stat" here?

Shouldn't "test -r", "! test -x", and their usual friends be
sufficient for the purpose of the test and are more portable?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]