Ray Donnelly <mingw.android@xxxxxxxxx> writes: > In normalize_ceiling_entry(), we test that normalized paths end with > slash, *unless* the path to be normalized was already the root > directory. > > However, normalize_path_copy() does not even enforce this condition. Perhaps the real issue to be addressed is the above, and your patch is killing a coalmine canary? Some callers of this function in real code (i.e. not the one you are removing the check) do seem to depend on that condition, e.g. the codepath in clone that leads to add_to_alternates_file() wants to make sure it does not add an duplicate, so it may end up not noticing /foo/bar and /foo/bar/ are the same thing, no? There may be others. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html