I'm going to have to attach this as a file, git-send-email isn't
working for me; apologies.
On Sat, Oct 3, 2015 at 1:44 PM, Ray Donnelly <mingw.android@xxxxxxxxx> wrote:
> In normalize_ceiling_entry(), we test that normalized paths end with
> slash, *unless* the path to be normalized was already the root
> directory.
>
> However, normalize_path_copy() does not even enforce this condition.
>
> Even worse: on Windows, the root directory gets translated into a
> Windows directory by the Bash before being passed to `git.exe` (or
> `test-path-utils.exe`), which means that we cannot even know whether
> the path that was passed to us was the root directory to begin with.
>
> This issue has already caused endless hours of trying to "fix" the
> MSYS2 runtime, only to break other things due to MSYS2 ensuring that
> the converted path maintains the same state as the input path with
> respect to any final '/'.
>
> So let's just forget about this test. It is non-essential to Git's
> operation, anyway.
>
> Ack-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> Signed-off-by: Ray Donnelly <mingw.android@xxxxxxxxx>
> ---
> test-path-utils.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/test-path-utils.c b/test-path-utils.c
> index 3dd3744..c67bf65 100644
> --- a/test-path-utils.c
> +++ b/test-path-utils.c
> @@ -21,8 +21,6 @@ static int normalize_ceiling_entry(struct
> string_list_item *item, void *unused)
> if (normalize_path_copy(buf, ceil) < 0)
> die("Path \"%s\" could not be normalized", ceil);
> len = strlen(buf);
> - if (len > 1 && buf[len-1] == '/')
> - die("Normalized path \"%s\" ended with slash", buf);
> free(item->string);
> item->string = xstrdup(buf);
> return 1;
> --
> 2.5.2
Attachment:
0001-test-path-utils.c-remove-incorrect-assumption.patch
Description: Binary data