On Sat, 17 Mar 2007, Linus Torvalds wrote: > > > On Sat, 17 Mar 2007, Morten Welinder wrote: > > > > > samples % app name symbol name > > > 41527 15.6550 git strlen > > > > Almost 16% in strlen? Ugh! > > > > That's a lot of strings, or perhaps very long strings. Or a profiling bug. > > It's likely real, and the problem is likely lots of small strings. > > Each git tree entry is: > > "<octal mode> name\0" <20-byte sha1> > > so you do have a *lot* of strlen() calls when doing any tree parsing. This is definitely an area where pack v4 will bring that cost down to zero. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html