Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



@Luke, Torsten, Eric, Junio:
Thanks for the great feedback. I incorporated everything into "[PATCH v3] git-p4: fix faulty paths for case insensitive systems”.
Is this the correct way? I have never worked with the email-patch-files before :-)

- Lars

On 20 Aug 2015, at 17:55, Junio C Hamano <gitster@xxxxxxxxx> wrote:

> Lars Schneider <larsxschneider@xxxxxxxxx> writes:
> 
>>>> +		find . | grep TWO/file1.txt &&
>>>> +		find . | grep TWO/File2.txt &&
>>>> +		find . | grep TWO/file3.txt &&
>>> Not sure about the find | grep here either.
>> See answers above.
> 
> These are not very good tests; they will match "OTWO/file1.txto",
> too.  Besides, it is wasteful to run find three times.
> 
>        find ?* -print | sort >actual &&
>        cat >expect <<-\EOF &&
>        TWO/file1.txt
>        ...
>        EOF
> 	test_cmp expect actual
> 
> or something like that instead?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]