Re: Minor annoyance with 'git interpret-trailers'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 20, 2015 at 6:37 PM, Matthieu Moy
<Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
> Hi,
>
> I use 'git interpret-trailers' as a commit-msg hook to add a
> Signed-off-by in a repository.
>
> When used in a one-line commit message formatted like
> 'foo: do something', the command interprets the one-line summary as a
> trailer, and inserts my Signed-off-by after it, without a blank line:
>
>     foo: do something
>     Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxx>
>
> This breaks the convention "One summary line, one blank line, and then
> body", and shows my sign-off in the output of "git log --oneline" :-(.
>
> I think the behavior "don't insert a newline if the last line looks like
> a trailer" should be disabled when the message is a one-liner.

Yeah, I agree. I will take a look at fixing that soon.

Thanks for the report,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]