Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > You replaced the quote_style argument with ref_formatting_state, and I > think you should have kept this argument and added ref_formatting_state. > The other option is to add an extra indirection like > > struct ref_formatting_state { > int quote_style; > struct ref_formatting_stack *stack; > } > > (ref_formatting_stack would be what you currently call > ref_formatting_state). But that's probably overkill. I think this is the right way to go. As you explained in your later messages, this is conceptually a global setting that applies to anybody working in the callchain and not something individual recursion levels would want to muck with. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html