On Fri, Aug 7, 2015 at 3:18 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >> On Fri, Aug 7, 2015 at 2:32 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> >>>>> If we followed what you just said, that patch will try to directly >>>>> read the data in config_name_for_path string list, which is removed >>>>> by Heiko's series, if I am reading it right. >>> >>> By the way, the above is more important part of the message you are >>> responding to. The result does not simply link, because your >>> unsorted_string_list_lookup() will no longer have the string list in >>> the first place X-<. >> >> I looked through Heikos series and think it is an improvement. I mean I >> can redo my patches on top of his. Specially this patch will be easy, >> as patch 2/4 (extract functions for submodule config set and lookup) >> implements get_name_for_path. All I would need to do then is expose it >> to the shell via the helper. > > Yes, that is exactly what I said a few messages ago, wasn't it? Yes, you did. I needed to repeat it to actually mentally process it. > > But that would require that you read and understand Heiko's work and > that you understand what its future direction should be, communicate > that vision to others to share, before building on top of it. And > with that effort, you would already be in a good position to polish > Heiko's stalled work and move it forward. After all, you cannot > just build on a stalled work, declare "my part is done; the result > is not mergeable because the foundation is not cooked, but that is > not my problem" ;-). That would be an easy world to live in, but I agree that I should get the fundamentals right. > > IIRC, the issues around the topic were nothing show-stopping, but > the primary reason it stalled was that Heiko got busy with his other > obligations, so I'd appreciate others like you to help the topic > move forward. Ok, I'll dig up the old reviews and review it myself before continuing on my patches. > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html