Karthik Nayak <karthik.188@xxxxxxxxx> writes: > On Tue, Jul 28, 2015 at 7:47 PM, Matthieu Moy > <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: >> >> I'm not sure what's the convention, but I think the test description >> should give the expected behavior even with test_expect_failure. >> >> And please help the reviewers by saying what's the status wrt this test >> (any plan on how to fix it?). >> > > On the other hand I wonder if the test is even needed as, we don't > really need it > Cause we remove that ability of branch.c by using filter_refs(). Please read d0f810f (refs.c: allow listing and deleting badly named refs, 2014-09-03). I think the reasoning makes sense, and we should keep this ability. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html