Karthik Nayak <karthik.188@xxxxxxxxx> writes: > -static void print_value(struct atom_value *v, int quote_style) > +static void apply_formatting_state(struct ref_formatting_state *state, > + struct atom_value *v, struct strbuf *value) > { > - struct strbuf sb = STRBUF_INIT; > - switch (quote_style) { > + /* Eventually we'll formatt based on the ref_formatting_state */ s/formatt/format/ Also, we usually use a single space after /*. (Neither is very important since it disapears in the next commit) > + /* > + * Some (pesudo) atoms have no immediate side effect, but only s/pesudo/pseudo/. But if you are to rename these atoms to "modifier atoms", you should get rid of this "pseudo" here. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html