Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Torsten Bögershausen <tboegi@xxxxxx> writes:

> #!/usr/bin/perl
>
> Should we have hard-coded PATH to perl here ?

This is what is done in other tests:

$ head t*/test.pl -n 1
==> t0202/test.pl <==
#!/usr/bin/perl

==> t9000/test.pl <==
#!/usr/bin/perl

==> t9700/test.pl <==
#!/usr/bin/perl

We actually don't use it when running the testsuite properly, since we
call

  perl "$TEST_DIRECTORY"/t9000/test.pl

and perl is defined as

  perl () {
  	command "$PERL_PATH" "$@"
  }

So, it's OK.

> /usr/bin/perl --version
> This is perl, v5.10.0 built for darwin-thread-multi-2level
> (with 2 registered patches, see perl -V for more detail)
>
>> +
>> +my $is_passing = Test::More->builder->is_passing;
>> +exit($is_passing ? 0 : 1);
>> 
>
> This seems to give problems:
> debug=t verbose=t ./t9000-addresses.sh

Indeed, is_passing seems too recent for your version of perl. A similar
problem was solved in t9700 by 635155f (t9700: Use Test::More->builder,
not $Test::Builder::Test, 2010-06-26). I'll use the same solution:

my $is_passing = eval { Test::More->is_passing };
exit($is_passing ? 0 : 1) unless $@ =~ /Can't locate object method/;

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]