Hi, On 2015-07-03 18:24, Stefan Beller wrote: > On Thu, Jul 2, 2015 at 11:16 AM, Paul Tan <pyokagan@xxxxxxxxx> wrote: >> Increase test coverage of git-am.sh to help prevent regressions that could arise >> from the rewrite of git-am.sh to C. This patch series, along with >> pt/am-foreign, improved test coverage as measured by kcov from 56.5%[1] to >> 67.3%[2]. >> >> No tests for git-am's interactive mode, though, as test_terminal does not seem >> to attach a pseudo-tty to stdin(?), thus making git-am's "test -t 0" check fail. >> >> This is part of my GSoC project to rewrite git-am.sh to a C builtin[3]. > > The whole series looks good to me. I concur (my two comments really are minor nit picks). Thanks, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html