On Thu, Jul 2, 2015 at 11:16 AM, Paul Tan <pyokagan@xxxxxxxxx> wrote: > Increase test coverage of git-am.sh to help prevent regressions that could arise > from the rewrite of git-am.sh to C. This patch series, along with > pt/am-foreign, improved test coverage as measured by kcov from 56.5%[1] to > 67.3%[2]. > > No tests for git-am's interactive mode, though, as test_terminal does not seem > to attach a pseudo-tty to stdin(?), thus making git-am's "test -t 0" check fail. > > This is part of my GSoC project to rewrite git-am.sh to a C builtin[3]. The whole series looks good to me. > > [1] http://pyokagan.github.io/git/20150430132408-a75942b//kcov-merged/git-am.eb79278e.html > [2] http://pyokagan.github.io/git/20150702173751-2fdae08//kcov-merged/git-am.eb79278e.html > [3] https://gist.github.com/pyokagan/1b7b0d1f4dab6ba3cef1 > > > Paul Tan (12): > t4150: am.messageid really adds the message id > t4150: am fails if index is dirty > t4151: am --abort will keep dirty index intact > t4150: am refuses patches when paused > t4150: am --resolved fails if index has no changes > t4150: am --resolved fails if index has unmerged entries > t4150: am with applypatch-msg hook > t4150: am with pre-applypatch hook > t4150: am with post-applypatch hook > t4150: tests for am --[no-]scissors > t3418: non-interactive rebase --continue with rerere enabled > t3901: test git-am encoding conversion > > t/t3418-rebase-continue.sh | 19 ++++ > t/t3901-i18n-patch.sh | 62 ++++++++++++ > t/t4150-am.sh | 228 +++++++++++++++++++++++++++++++++++++++++++++ > t/t4151-am-abort.sh | 15 +++ > 4 files changed, 324 insertions(+) > > -- > 2.5.0.rc1.81.gfe77482 > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html