On Thu, Jul 2, 2015 at 10:42 PM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > Karthik Nayak <karthik.188@xxxxxxxxx> writes: > >> 'tag -l' and 'branch -l' have two different ways of finding >> out if a certain ref contains a commit. Implement both these >> methods in ref-filter and give the caller of ref-filter API >> the option to pick which implementation to be used. > > You are reusing some code, but unlike the other patches you are not > marking the old code as duplicated. The "duplicate code" comment both > acts as a reminder for later, and as an indication for reviewers of > where the code comes from. > Ah! I didn't really mark it cause unlike the others this isn't a single function but rather a whole block of code, but what you're saying makes sense. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html