Re: [PATCH v7 10/11] ref-filter: implement '--contains' option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Karthik Nayak <karthik.188@xxxxxxxxx> writes:

> 'tag -l' and 'branch -l' have two different ways of finding
> out if a certain ref contains a commit. Implement both these
> methods in ref-filter and give the caller of ref-filter API
> the option to pick which implementation to be used.

You are reusing some code, but unlike the other patches you are not
marking the old code as duplicated. The "duplicate code" comment both
acts as a reminder for later, and as an indication for reviewers of
where the code comes from.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]