Re: [PATCH v9 5/5] bisect: allow any terms set by user

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:

> This is currently how it's implemented. You need to say
>
> $ git bisect terms foo bar
> $ git bisect start

Ahh, it means everything including the description (i.e. "you start
bisection") is consistent and perfectly fine.

I misread the patch, it seems.  Sorry for the noise.

Thanks.

> And indeed "git bisect terms foo bar" errors out. I think the reason it
> is this way is to allow
>
> $ git bisect terms foo bar
> $ git bisect start <sha1> <sha1>
>
> But actually, we can allow "git bisect terms" until BISECT_TERMS is
> created, which is your intuition and makes more sense IMHO. I'll try to
> do that.

I am not sure if it is a good idea, though.  Matching the intuition
of those who (think they) know how it is implemented is much less
important than providing a behaviour that is simple to explain to
casual users.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]