Re: [PATCH v9 5/5] bisect: allow any terms set by user

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> And worse yet, majority of users may read "git bisect start" is
> where "you start bisection", but "bisect start" (either called
> directly, or via bisect_autostart by the first "git bisect good")
> is where you set up the machinery, so doing "bisect terms" before
> doing "bisect start" does not make much sense.

This is currently how it's implemented. You need to say

$ git bisect terms foo bar
$ git bisect start

And indeed "git bisect terms foo bar" errors out. I think the reason it
is this way is to allow

$ git bisect terms foo bar
$ git bisect start <sha1> <sha1>

But actually, we can allow "git bisect terms" until BISECT_TERMS is
created, which is your intuition and makes more sense IMHO. I'll try to
do that.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]