Re: [PATCH 5/6] Fix some "comparison is always true/false" warnings.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2007-03-07 19:05:49 +0000, Ramsay Jones wrote:

> Karl Hasselström wrote:
>
> > Umm ... wouldn't an uint32_t be a better fit here?
>
> Yes, but I did not want to add a dependency on a C99 header (i.e.
> <stdint.h>). I had a vague recollection that Linus had stated that
> git was probably broken if int wasn't 32 bits, so ...
>
> This was before I realized that a recent change to git meant that
> git was already including C99 headers <inttypes.h> and, therefore
> indirectly, <stdint.h>.

Your approach is much more sophisticated than mine. :-) I just
thought, "wow, this _screams_ for a uint32_t -- hmm, is it OK to use
that?", and then did "git grep uint32_t" and got about a screenful of
hits.

-- 
Karl Hasselström, kha@xxxxxxxxxxx
      www.treskal.com/kalle
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]