Re: [PATCH 5/6] Fix some "comparison is always true/false" warnings.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Karl Hasselström wrote:
On 2007-03-03 18:28:57 +0000, Ramsay Jones wrote:

+typedef unsigned int ucs_char_t;  /* assuming 32bit int */

Umm ... wouldn't an uint32_t be a better fit here?


Yes, but I did not want to add a dependency on a C99 header
(i.e. <stdint.h>). I had a vague recollection that Linus had
stated that git was probably broken if int wasn't 32 bits, so ...

This was before I realized that a recent change to git meant
that git was already including C99 headers <inttypes.h> and,
therefore indirectly, <stdint.h>.

So, if it is OK to depend on those headers, then an uin32_t may
indeed be a better fit.

All the best,

Ramsay Jones



-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]