Jeff King <peff@xxxxxxxx> writes: >> >> 1. in blame, we assign the result to a const char that may also point >> >> straight into to argv, but we never actually free either way >> >> The return value from add_prefix() that is what prefix_path() >> returned eventually becomes scoreboard.path that needs to be kept >> during the lifetime of the process, and I think there isn't much >> point doing the "free() immediately before exiting". > > Yeah, sorry, I meant to say that more explicitly, but clearly didn't. I > think it is fine as-is. Yeah, sorry, I didn't mean "You are wrong and here is why". I was merely agreeing with you. Thanks for running grep over the codebase to check possible remaining problems. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html