Re: [PATCH 2/4] revision traversal: retire BOUNDARY_SHOW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

>> > This should help performance, as not all reachable commits are traversed 
>> > any more.
>> 
>> You prevented that with "while (i &&" part already, didn't you?
>
> Well, yes. I also wanted to prevent going down all paths, though.

If we wanted to bundle "-8 A B", I think we would make 'x' and
'y' prereqs, as they are the direct parents commits that are
shown, and that themselves are not shown.

         .---*---*---*---*---* A
        /
    ---x---y---*---*---* B

If we say upon hitting prereq (x and y) we stop traversal by
marking the parent UNINTERESTING, I suspected that we may not
find out 'x' with get_revision() loop, and that was why I chose
not to.  Instead the loop stops by finding y and then x (and by
saying "ok I needed to find two and now I have two".

But this probably needs more optimization.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]