On Tue, Mar 06, 2007 at 03:05:55AM -0800, Junio C Hamano wrote: > > Ah, I understand your point now. Yes, if other mod_perl CGIs can impact > > the value, then we should definitely set it explicitly, as per your > > patch (and we should use Li's patch for safety, then, not mine). > > Reading "sub autoEscape", "sub escapeHTML" and "sub > self_or_default" again, I think other people cannot affect the > value of our $cgi->{'escape'} by calling autoEscape, so what I > said is probably bogus. Let's use Li's original patch. Er, sorry, yes, I just accidentally agreed with your bogosity (while figuring out what you originally meant, I forgot which CGI we were talking about!). So I agree, Li's original is sufficient. Sorry for the noise. :) -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html