On Sun, Apr 26, 2015 at 03:04:56PM -0700, Junio C Hamano wrote: > Good eyes. While fixing the test is necessary, we should also be > able to improve the test framework to prevent such mistakes at the > same time. > > ok 38 # skip > git clone "[myhost:123]:src" ssh-bracket-clone && > expect_ssh myhost -p (missing bracketed hostnames are still > ssh) > > The test scripts are expected to take either 3 or 4 parameters, and > the extra parameter when it takes 4 is the comma separated list of > prerequisites. "bracketed hostnames are still ssh" does not look > like prerequisites at all to us humans, and the framework should > also be able to notice that and barf, I would think. > > Perhaps something like this? I think this is a good change. I haven't tested to see if we have any other issues in the testsuite that this would expose, but if so, they should be easy enough to fix up. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Attachment:
signature.asc
Description: Digital signature