On Tue, Mar 17, 2015 at 7:18 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Dongcan Jiang <dongcan.jiang@xxxxxxxxx> writes: >> diff --git a/t/t4052-stat-output.sh b/t/t4052-stat-output.sh >> index b68afef..a989e8f 100755 >> --- a/t/t4052-stat-output.sh >> +++ b/t/t4052-stat-output.sh >> @@ -99,7 +99,7 @@ do >> test_cmp "$expect" actual >> ' >> >> - test "$cmd" != diff || continue >> + test "$cmd" != diff -a "$cmd" != show || continue > > I think we avoid -a and -o used with test (don't we have a write-up > on this somewhere?). The very last item in the shell script section of CodingGuidelines discusses it. > Write it like this > > test "$cmd" != diff && > test "$cmd" != show || continue > > or perhaps like this > > case "$cmd" in diff|show) continue ;; esac -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html