Dongcan Jiang <dongcan.jiang@xxxxxxxxx> writes:
> Because "--graph" is about connected history while --no-walk
> is about discrete points, it does not make sense to allow
> giving these two options at the same time. [1]
>
> This change makes a few calls to "show --graph" fail in
> t4052, but asking to show one commit with graph is a
> nonsensical thing to do. Thus, tests on "show --graph" in
> t4052 have been removed. [2,3] Same tests on "show" without
> --graph option have already been tested in 4052.
This looks almost perfect.
>
> diff --git a/t/t4052-stat-output.sh b/t/t4052-stat-output.sh
> index b68afef..a989e8f 100755
> --- a/t/t4052-stat-output.sh
> +++ b/t/t4052-stat-output.sh
> @@ -99,7 +99,7 @@ do
> test_cmp "$expect" actual
> '
>
> - test "$cmd" != diff || continue
> + test "$cmd" != diff -a "$cmd" != show || continue
I think we avoid -a and -o used with test (don't we have a write-up
on this somewhere?). Write it like this
test "$cmd" != diff &&
test "$cmd" != show || continue
or perhaps like this
case "$cmd" in diff|show) continue ;; esac
Other than that I do not see anything objectionable.
Thanks, good job.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html