On Sun, Mar 15, 2015 at 3:07 PM, Alexander Kuleshov <kuleshovmail@xxxxxxxxx> wrote: > t3700-add: added test for --exclude option s/added/add/ > Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx> > --- > diff --git a/t/t3700-add.sh b/t/t3700-add.sh > index f7ff1f5..6f71c67 100755 > --- a/t/t3700-add.sh > +++ b/t/t3700-add.sh > @@ -332,4 +332,22 @@ test_expect_success 'git add --dry-run --ignore-missing of non-existing file out > test_i18ncmp expect.err actual.err > ' > > +test_expect_success 'Test that "git add --exclude" works' ' Rather than inventing a new title style, try to match the style of the existing tests titles in this file. > + >foo && > + >bar && > + git add --exclude=bar . && > + ! (git ls-files | grep bar) Broken &&-chain. > + (git ls-files | grep foo) Unnecessary additional git-ls-files invocation. You could just save the output to a file and then process that file. > +' > + > +test_expect_success 'Test multiply --exclude' ' s/multiply/multiple/ Ditto: Match existing title style. > + >foo && > + >bar && > + >"b a z" && > + git add --exclude="bar" --exclude="b a z" . && > + (git ls-files | grep foo) > + ! (git ls-files | grep "b a z") > + ! (git ls-files | grep "baz") Broken &&-chain throughout. Ditto: Unnecessary git-ls-files invocations. > +' > + > test_done > -- > 2.3.3.472.g20ceeac.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html