On 03/08/2015 10:08 AM, Eric Sunshine wrote:
On Sat, Mar 7, 2015 at 5:49 AM, karthik nayak <karthik.188@xxxxxxxxx> wrote: >> This iteration looks sensible, except that the Subject reads >> strange. Will queue with minor tweaks to the log message, >> and perhaps with a fix to unreadable *(*argv)[1] that was >> mentioned elsewhere. > > Hey could you tell me what seems strange, so I can improve on > it the next time. Junio means that you somehow botched the Subject: line when you copied the commit message I suggested into your new version of the patch. Instead of <path>, you wrote <treat>.
Oops! I'm too anxious i guess.
> Also "*(*argv)[1]" seems more readable to me, maybe more of a perspective? I also had considered suggesting (*argv)[1][0] as more readable, but it is primarily personal taste, and I didn't want to bike-shed the issue.
Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html