Re: [PATCH v4] git: treat "-C <treat>" as a no-op when <path> is empty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> This iteration looks sensible, except that the Subject reads
> strange.  Will queue with minor tweaks to the log message,
> and perhaps with a fix to unreadable *(*argv)[1] that was
> mentioned elsewhere.
>
> Thanks.

Hey could you tell me what seems strange, so I can improve on
it the next time.
Also "*(*argv)[1]" seems more readable to me, maybe more of a perspective?

Thanks


On 03/07/2015 07:49 AM, Eric Sunshine wrote:
On Fri, Mar 6, 2015 at 6:18 AM, Karthik Nayak <karthik.188@xxxxxxxxx> wrote:
'git -C ""' unhelpfully dies with error "Cannot change to ''",
whereas the shell treats `cd ""' as a no-op. Taking the shell's
behavior as a precedent, teach git to treat `-C ""' as a no-op, as
well.

Test to check the no-op behaviour of "-C <path>" when <path> is
empty, written by Junio C Hamano.

Helped-by: Junio C Hamano <gitster@xxxxxxxxx>
Helped-by: Eric Sunchine <sunshine@xxxxxxxxxxxxxx>

s/Sunchine/Sunshine/

Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx>

Sorry Eric for the genuine mistake.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]