Re: [PATCHv2] commit: reword --author error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 26, 2015 at 04:48:33PM +0100, Michael J Gruber wrote:

> -	die(_("No existing author found with '%s'"), name);
> +	die(_("--author '%s': neither 'Name <email>' nor a match for an existing author"), name);

I had to add to the bikeshed, but I had to read this several times to
make sense of it. It is grammatically:

  X [is] neither Y nor Z

except that by eliding the verb ("is"), I somehow had trouble making
sense of Z ("a match...") as a noun.

I came up with:

  --author '%s': neither 'Name <email>' nor matches an existing author

only to see that it was suggested earlier in the thread as a predecessor
to this. ;)

I wonder if adding back in the missing verb, rather than a colon, would
also make more sense:

  --author '%s' is neither 'Name <email>' nor a match for an existing author

> BTW: How do you pull cc/msgid from the list into format-patch/send-email most effectively?
> (granted that I move away from gmane/nntp, which is likely)

Here's what I do:

  http://article.gmane.org/gmane.comp.version-control.git/262367

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]