Hi Junio,
On Tue, 23 Dec 2014, Junio C Hamano wrote:
> Having said that, I think "missingTags" etc. should not be configuration
> variable names (instead, they should be values).
>
> Because of that, I do not think we need consistency between the way
> these "tokens that denote kinds of errors fsck denotes" are spelled and
> the way "configuration variable names" are spelled.
Okay. That makes more sense.
Now I can remove the complexity introduced by teaching the parser to
accept camelCased values, and we're golden.
> In either case, I'd recommend that we take [ ,]+ as inter-token
> separator to ease the use on the command line and config file
And this is indeed the case:
+void fsck_strict_mode(struct fsck_options *options, const char *mode)
+...
+ while (*mode) {
+ int len = strcspn(mode, " ,|"), equal, msg_id;
+...
In other words, I even allowed the pipe symbol as separator.
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html