On Sun, Dec 7, 2014 at 8:18 AM, Jeff King <peff@xxxxxxxx> wrote: > On Sat, Dec 06, 2014 at 10:04:06PM +0100, Torsten Bögershausen wrote: > >> I get this: >> >> >> expecting success: >> check_language "ko-KR, *;q=0.1" ko_KR.UTF-8 de_DE.UTF-8 ja_JP.UTF-8 en_US.UTF-8 && >> check_language "de-DE, *;q=0.1" "" de_DE.UTF-8 ja_JP.UTF-8 en_US.UTF-8 && >> check_language "ja-JP, *;q=0.1" "" "" ja_JP.UTF-8 en_US.UTF-8 && >> check_language "en-US, *;q=0.1" "" "" "" en_US.UTF-8 >> >> --- expect 2014-12-06 21:00:59.000000000 +0000 >> +++ actual 2014-12-06 21:00:59.000000000 +0000 >> @@ -1 +0,0 @@ >> -Accept-Language: de-DE, *;q=0.1 >> not ok 25 - git client sends Accept-Language based on LANGUAGE, LC_ALL, LC_MESSAGES and LANG > > I can reproduce the same problem here (Debian unstable). I actually ran > into three issues (aside from needing to use Junio's SQUASH commit, to > avoid the "\r" bash-ism): > > 1. I couldn't build without including locale.h, for the > definition of setlocale() and the LC_MESSAGES constant (both used > in get_preferred_languages). > > I'm not sure what portability issues there are with including it > unconditionally. Should this possibly be tied into gettext.c, which > already uses setlocale? Yeah, pu build is broken on Ubuntu 14.04 too, because of 7567fad2431eb38291fd74a70f603e5746c6f728 (http: send Accept-Language header if possible). Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html