jrnieder@xxxxxxxxx wrote on Tue, 18 Nov 2014 10:43 -0800: > ... and here's a patch on top to give git-p4 the same treatment. > > -- >8 -- > Subject: Makefile: have python scripts depend on NO_PYTHON setting > > Like the perl scripts, python scripts need a dependency to ensure they > are rebuilt when switching between the "dummy" versions that run > without Python and the real thing. > > Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > --- > Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Makefile b/Makefile > index 8f980e0..7482a4d 100644 > --- a/Makefile > +++ b/Makefile > @@ -1736,6 +1736,9 @@ $(SCRIPT_PERL_GEN) git-instaweb: % : unimplemented.sh > mv $@+ $@ > endif # NO_PERL > > +# This makes sure we depend on the NO_PYTHON setting itself. > +$(SCRIPT_PYTHON_GEN): GIT-BUILD-OPTIONS > + > ifndef NO_PYTHON > $(SCRIPT_PYTHON_GEN): GIT-CFLAGS GIT-PREFIX GIT-PYTHON-VARS > $(SCRIPT_PYTHON_GEN): % : %.py > -- > 2.1.0.rc2.206.gedb03e5 Looks obviously correct, thanks for remembering the other scripting languages. :) Acked-by: Pete Wyckoff <pw@xxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html