On Tue, Nov 18, 2014 at 10:38:38AM -0800, Jonathan Nieder wrote:
> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
Thanks.
> > +# This makes sure we depend on the NO_PERL setting itself.
> > +$(patsubst %.perl,%,$(SCRIPT_PERL)): GIT-BUILD-OPTIONS
> > +
> > ifndef NO_PERL
> > $(patsubst %.perl,%,$(SCRIPT_PERL)): perl/perl.mak
>
> Why do these repeat the 'patsubst ...' expression instead of using
> SCRIPT_PERL_GEN, by the way?
Dunno. I just cargo-culted from the context lines.
> -- >8 --
> Subject: Makefile: simplify by using SCRIPT_{PERL,SH}_GEN macros
>
> SCRIPT_PERL_GEN is defined as $(patsubst %.perl,%,$(SCRIPT_PERL)) for
> use in targets like build-perl-script used by makefiles in
> subdirectories that override SCRIPT_PERL (see v1.8.2-rc0~17^2,
> "git-remote-mediawiki: use toplevel's Makefile", 2013-02-08).
>
> The same expression is used in the rules that actually write the
> generated perl scripts, and since this rules were introduced before
> SCRIPT_PERL_GEN, they use the longhand instead of that macro. Use the
> macro to make reading easier.
>
> Likewise for SCRIPT_SH_GEN. The Python rules already got the same
> simplification in v1.8.4-rc0~162^2~8 (2013-05-24).
This makes sense, and looking over the Makefile, I don't see how it
could cause any bad side effects.
Minor nit:
s/this rules/these rules/
in your commit message. Otherwise:
Reviewed-by: Jeff King <peff@xxxxxxxx>
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html