On Wed, Sep 10, 2014 at 2:55 PM, Jeff King <peff@xxxxxxxx> wrote: > BTW, while grepping for commit_lock_file calls, I notice we often commit > the shallow file without checking the return code. I'm not sure what we > should do in each case, but I imagine that calling die() is probably > better than continuing as if it succeeded. +cc Duy Noted. To be fixed soon. It looks like we could make gcc warn about ignoring return code like this with __attribute__((warn_unused_result)) (but I haven't tested). If it does help catch mishandling in future commit_lock_file calls and does not upset other compilers, we may want to add it to commit_lock_file. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html