The ta/config-set API is more or less solidified. This series builds on the top of 4c715ebb in pu (ta/config-set). On top of it, it also requires series [1] (Rewrite `git_config()` using config-set API) for proper error checking. This series is the first batch of patches which rewrites the existing callers using a non-callback approach. This series aims to, * rewrite the existing callers, as you can see from the diff stat the bew API provides a much concise and clear control flow. * stress test the new API, see if any corner cases or deficiencies arise or not. The series passes all the tests, only thing to watch is that the config variables that have been rewritten are single valued only. Though I have tried my best to ascertain it, still mistakes may arise. p.s: I haven't decided yet about whether to introduce a new helper set, for example git_config_get_value_fmt() which would behave like strbuf_addf(). It will probably come in a later series. [1]: http://thread.gmane.org/gmane.comp.version-control.git/254633/ Tanay Abhra (11): alias.c | 25 ++++++------------------ archive.c | 12 +++--------- branch.c | 27 +++++++------------------- builtin/gc.c | 51 +++++++++++++++++++----------------------------- daemon.c | 27 +++++--------------------- fetch-pack.c | 35 ++++++++------------------------- http-backend.c | 31 ++++++++++++----------------- imap-send.c | 61 ++++++++++++++++++++++++++-------------------------------- pager.c | 40 +++++++++++++------------------------- read-cache.c | 14 +++----------- rerere.c | 43 ++++++++++++----------------------------- 11 files changed, 116 insertions(+), 250 deletions(-) -- 1.9.0.GIT -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html