Junio C Hamano <gitster@xxxxxxxxx> writes: > Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > >> This allows a caller to requst the global config file without requesting >> the XDG one. >> >> Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxx> >> --- >> This is actually not needed, but I wrote this for a previous version, >> and it seems sensible anyway. > > I was about to say "Let's not do this until some caller needs it", > implicitly assuming that we do not let global=NULL to signal that > the caller is interested only in XDG, but I checked and we do check > the NULL-ness of global, so it is consistent to do so for xdg. The > change makes very good sense. > > I wouldn't have had to spend the time to dig, if the log message > justified it that way, instead of having "actually not needed" > comment there ;-) > > home_config_paths(): let the caller ignore xdg path > > The caller can signal that it is not interested in learning > the location of $HOME/.gitconfig by passing global=NULL, but > there is no way to decline the ptah to the configuration > file based on $XDG_CONFIG_HOME. > > Allow the caller to pass xdg=NULL to signal that it is not > interested in the XDG location. Good point. Applied locally, I'll resend later. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html