Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
>> +static char *default_user_config()
>> +{
>> + struct strbuf buf = STRBUF_INIT;
>> + strbuf_addf(&buf,
>> + _("# This is Git's user-wide configuration file.\n"
>> + "[core]\n"
>> + "# Please, adapt and uncomment the following lines:\n"
>> + "# user = %s\n"
>> + "# email = %s\n"),
>
> "[core]", "user =", "email =" should not be translated. Would it make
> sense to keep these outside of _()?
I would say no, as the code and the string to translate would be much
less readable without core, user and email inline.
Were you suggesting stg like
_("# This is Git's user-wide configuration file.\n"
"[%s]\n"
"# Please, adapt and uncomment the following lines:\n"
"# %s = %s\n"
"# %s = %s\n"),
"core", "name", ..., "email", ...
?
>> + if (fd) {
>> + char *content = default_user_config();
>> + write_str_in_full(fd, content);
>
> close(fd);
Indeed.
>> + free(content);
>> + }
>> + else if (errno != EEXIST)
>> + die_errno(_("Cannot create configuration file %s"), config_file);
>
> Other error messages in this file (including those just above this
> block) begin with a lowercase letter.
Applied.
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html