Tanay Abhra <tanayabh@xxxxxxxxx> writes: > On 7/25/2014 12:01 AM, Junio C Hamano wrote: >> Tanay Abhra <tanayabh@xxxxxxxxx> writes: >> >>> On 7/24/2014 3:19 AM, Junio C Hamano wrote: >>>> Tanay Abhra <tanayabh@xxxxxxxxx> writes: >>>> >>>>> If a callback returns a negative value to `git_config*()` family, >>>>> they call `die()` while printing the line number and the file name. >>>>> Currently the printed line number is off by one, thus printing the >>>>> wrong line number. >>>>> >>>>> Make `linenr` point to the line we just parsed during the call >>>>> to callback to get accurate line number in error messages. >>>>> >>>>> Discovered-by: Tanay Abhra <tanayabh@xxxxxxxxx> >>>>> Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> > > This patch should have looked like, > > From: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> > > <commit message> > > Commit-message-by: Tanay Abhra <tanayabh@xxxxxxxxx> Yes, the code itself was mine, and Tanay wrote the commit message. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html