On 7/25/2014 12:01 AM, Junio C Hamano wrote: > Tanay Abhra <tanayabh@xxxxxxxxx> writes: > >> On 7/24/2014 3:19 AM, Junio C Hamano wrote: >>> Tanay Abhra <tanayabh@xxxxxxxxx> writes: >>> >>>> If a callback returns a negative value to `git_config*()` family, >>>> they call `die()` while printing the line number and the file name. >>>> Currently the printed line number is off by one, thus printing the >>>> wrong line number. >>>> >>>> Make `linenr` point to the line we just parsed during the call >>>> to callback to get accurate line number in error messages. >>>> >>>> Discovered-by: Tanay Abhra <tanayabh@xxxxxxxxx> >>>> Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> This patch should have looked like, From: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> <commit message> Commit-message-by: Tanay Abhra <tanayabh@xxxxxxxxx> >>> >>> Thanks. >>> >>> I am not sure what to read in these two lines. Was the fix done by >>> you or Matthieu? >>> >> >> I misunderstood the meaning of the message trailers. I will correct >> it in the next re roll. > > Well, that does not really answer my question, and it does not tell > us if you now understand the meaning of trailers correctly, or > replaced an earlier misunderstanding with a different > misunderstanding ;-) > > More importantly, it would not help me interpret what you mean when > you write a sequence like this: > > From: tanay > S-o-b: matthieu > S-o-b: tanay > Actually it was because that patch contained fixup patch from Matthieu squashed into it, that is why there were two signoffs. > which does not quite make sense and leave the reader puzzled. > > If the patch was authored by you and helped by matthieu, the first > S-o-b would be lying. If the patch was written by matthieu and you > are merely relaying, then the authorship From is lying. If the > patch was written by you and matthieu is relaying, then the two > S-o-bs are in incorrect order. > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html