On Mon, Jun 30, 2014 at 08:59:53PM +0700, Duy Nguyen wrote:
> On Mon, Jun 30, 2014 at 8:43 PM, Jeff King <peff@xxxxxxxx> wrote:
> >> diff --git a/sha1_file.c b/sha1_file.c
> >> index 394fa45..8adab14 100644
> >> --- a/sha1_file.c
> >> +++ b/sha1_file.c
> >> @@ -1207,7 +1207,8 @@ static void prepare_packed_git_one(char *objdir, int local)
> >> if (has_extension(de->d_name, ".idx")) {
> >> /* Don't reopen a pack we already have. */
> >
> > If we don't follow my suggestion above, we still have this
> > has_extension. This is a reimplementation of ends_with, isn't it? We can
> > probably drop it and just use ends_with.
>
> This calls for another patch if we just want to kill has_extension()
> in favor of ends_with(). There are 12 call sites of it.
Yes. Some of those would want to become ends_with, and some would
actually want to become strip_suffix. I'm working up a series now.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html