On Wed, May 21, 2014 at 10:37:05AM -0700, Junio C Hamano wrote: > > I wasn't planning on anything as drastic as stripspace. I really just > > wanted to suppress the one newline, which is almost certainly the right > > thing to include for "--signature", but the wrong thing for > > "--signature-file" (i.e., the patch I posted earlier). > > ... > > I dunno. Maybe it is not worth caring too much about. > > I suggested stripspace() because I know we do not care too > much, actually. > > Cleansing blank lines in one way for many types of user input > (e.g. commit log messages and tag messages) while doing it in a > completely different way just for "--signature-file" is warranted if > there is a good reason for them to be different, but I did not think > of any, and I still don't. So... I didn't think of mine as cleansing. It is more like "do not duplicate a newline ourselves if there is already one there". But I guess those are two sides of the same coin. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html