On Tue, May 20, 2014 at 10:53:11AM -0700, Junio C Hamano wrote: > I actually think these "supress extra LFs" trying to be overly smart > and inviting unnecessary surprises. Unlike log messages people type > (in which we do squash runs of blank lines and other prettifying), > mail-signature string is not something people keep typing, and it > would be better to keep it simple and consistent, i.e. we can > declare that the users who use non-default mail-signature can and > should learn to: > > --signature='this is the first line of my long sig > > with a blank line and then it ends here' > > and be done with it, I think. If it were just "--signature", I'd agree. After all, nobody is even complaining. But this is also in preparation for --signature-file. Should the user create a file without a trailing newline? We can special-case --signature-file to strip the final newline from the read file, but it seems friendlier to handle it at the printing stage (and then we handle the unlikely but possible --signature as above for free). I don't think it would adversely impact any real-world case, because somebody would have to: 1. already be including an extra trailing newline 2. really _want_ three newlines at the end > The trailing blank after the mail-signature is a different issue. I > think it is safe to remove it and I also think the result may look > better, but at the same time, it is very close to the "if we were > writing format-patch today, then we would..." category, I would say. Yeah. I think it is probably extraneous and would not hurt to remove. But it may not be worth worrying about (it's really the _two_ lines caused by the unconditional newline above that bugs me). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html