Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Nieder <jrnieder@xxxxxxxxx> writes:

>>> +		if (opt.ignore_case && !strcmp("less", pager))
>>> +			string_list_append(&path_list, "-i");
>>
>> I have a feeling that this goes against the recent trend of not
>> mucking with the expectation of the users on their pagers, if I
>> recall correctly the arguments for dropping S from the default given
>> to an unconfigured LESS environment variable.
>
> It's just missing an explanation.
> ...
> (That's -I, not -i, because it ought to work even when the pattern
> contains capital letters.)

Spot on.  The change, especially with "-I", makes sense.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]