Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Stepan Kasal <kasal@xxxxxx> writes:

> From: Johannes Schindelin <johannes.schindelin@xxxxxx>
> Date: Tue, 8 Feb 2011 00:17:24 -0600
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> Signed-off-by: Stepan Kasal <kasal@xxxxxx>
> ---
> Hi,
> this patch has been in msysgit for 3 1/4 years.
>   Stepan
>
>  builtin/grep.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/builtin/grep.c b/builtin/grep.c
> index 8073fbe..6c82a29 100644
> --- a/builtin/grep.c
> +++ b/builtin/grep.c
> @@ -897,6 +897,9 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
>  		if (len > 4 && is_dir_sep(pager[len - 5]))
>  			pager += len - 4;
>  
> +		if (opt.ignore_case && !strcmp("less", pager))
> +			string_list_append(&path_list, "-i");

I have a feeling that this goes against the recent trend of not
mucking with the expectation of the users on their pagers, if I
recall correctly the arguments for dropping S from the default given
to an unconfigured LESS environment variable.

>  		if (!strcmp("less", pager) || !strcmp("vi", pager)) {
>  			struct strbuf buf = STRBUF_INIT;
>  			strbuf_addf(&buf, "+/%s%s",
> -- 
> 1.9.2.msysgit.0.335.gd2a461f
>
> -- 
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]